Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version stabilization for 17. 6 release #894

Merged
merged 3 commits into from
Mar 17, 2023
Merged

Version stabilization for 17. 6 release #894

merged 3 commits into from
Mar 17, 2023

Conversation

ankitvarmait
Copy link
Contributor

Version stabilization for 17. 6 release

@ankitvarmait
Version stabilization for 17. 6 release
3d9ede2 
Version stabilization for 17. 6 release
AArnott
AArnott approved these changes Mar 9, 2023
View reviewed changes
Copy link
Member

@AArnott AArnott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, provided you've tested with dotnet pack -p:publicrelease=true with this change applied. The PR build doesn't test this, but the CI build may break if issues that this dotnet pack command could also find are not fixed.

@RyanToth3
Copy link
Member

This references an unstable version of Threading

@RyanToth3 RyanToth3 self-requested a review March 10, 2023 00:37
@ankitvarmait
Copy link
Contributor Author

Looks good, provided you've tested with dotnet pack -p:publicrelease=true with this change applied. The PR build doesn't test this, but the CI build may break if issues that this dotnet pack command could also find are not fixed.

dotnet pack -p:publicrelease=true

Build succeeded.
0 Warning(s)
0 Error(s)

@ankitvarmait
Copy link
Contributor Author

This references an unstable version of Threading

I ran the command dotnet pack -p:publicrelease=true

Build succeeded.
0 Warning(s)
0 Error(s)

Do you know how to validate this reference >

@AArnott
Copy link
Member

AArnott commented Mar 10, 2023

@ankitvarmait are you saying you can't repro the problem that @RyanToth3 saw? I see it as well:

C:\Program Files\dotnet\sdk\7.0.103\Sdks\NuGet.Build.Tasks.Pack\buildCrossTargeting\NuGet.Build.Tasks.Pack.targets(221,5): warning NU5104: A stable release of a package should not have a prerelease dependency. Either modify the version spec of dependency "Microsoft.VisualStudio.Threading [17.6.29-alpha, )" or update the version field in the nuspec. [C:\Users\andarno\source\repos\vs-streamjsonrpc\src\StreamJsonRpc\StreamJsonRpc.csproj]
C:\Program Files\dotnet\sdk\7.0.103\Sdks\NuGet.Build.Tasks.Pack\buildCrossTargeting\NuGet.Build.Tasks.Pack.targets(221,5): warning NU5104: A stable release of a package should not have a prerelease dependency. Either modify the version spec of dependency "Microsoft.VisualStudio.Threading.Analyzers [17.6.29-alpha, )" or update the version field in the nuspec. [C:\Users\andarno\source\repos\vs-streamjsonrpc\src\StreamJsonRpc\StreamJsonRpc.csproj]
C:\Program Files\dotnet\sdk\7.0.103\Sdks\NuGet.Build.Tasks.Pack\buildCrossTargeting\NuGet.Build.Tasks.Pack.targets(221,5): warning NU5104: A stable release of a package should not have a prerelease dependency. Either modify the version spec of dependency "Microsoft.VisualStudio.Threading [17.6.29-alpha, )" or update the version field in the nuspec. [C:\Users\andarno\source\repos\vs-streamjsonrpc\src\StreamJsonRpc\StreamJsonRpc.csproj]
C:\Program Files\dotnet\sdk\7.0.103\Sdks\NuGet.Build.Tasks.Pack\buildCrossTargeting\NuGet.Build.Tasks.Pack.targets(221,5): warning NU5104: A stable release of a package should not have a prerelease dependency. Either modify the version spec of dependency "Microsoft.VisualStudio.Threading.Analyzers [17.6.29-alpha, )" or update the version field in the nuspec. [C:\Users\andarno\source\repos\vs-streamjsonrpc\src\StreamJsonRpc\StreamJsonRpc.csproj]
    4 Warning(s)
    0 Error(s)

We need to stabilize vs-threading first, spin a real-signed build, and then we can update that reference here in this repo and merge it before or with this PR.

@javierdlg
Copy link
Member

javierdlg commented Mar 14, 2023 •
edited
Loading

@ankitvarmait you should make sure the package that is being built doesn't have an alpha tag. The pack command requires a new git commit for it to pick up the changes. I saw no errors initially, but after running dotnet nuget locals -c http-cache, committing a new change, and running dotnet pack -p:publicrelease=true I was able to get the preview version warnings.

I've opened a PR on vs-threading for this:
microsoft/vs-threading#1166

@ankitvarmait
Copy link
Contributor Author

Microsoft.VisualStudio.Threading
@AArnott
I figured out why the command wasn't giving me a warning error. I ran the 'Clean' command before the other command, and now I can see the warning. . Thanks for the feedback.

@AArnott AArnott enabled auto-merge (squash) March 17, 2023 14:36
@AArnott AArnott merged commit f83294b into microsoft:main Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AArnott AArnott AArnott approved these changes

@RyanToth3 RyanToth3 Awaiting requested review from RyanToth3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ankitvarmait @RyanToth3 @AArnott @javierdlg